-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add assertion for correct resolution of delegatee oobi #252
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
=======================================
Coverage 83.82% 83.82%
=======================================
Files 48 48
Lines 4229 4229
Branches 1034 1021 -13
=======================================
Hits 3545 3545
- Misses 656 680 +24
+ Partials 28 4 -24 ☔ View full report in Codecov by Sentry. |
I've updated this PR now to only include the assertion for the issue WebOfTrust/keria#230 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I did this as a step to try and resolve what was failing the multisig vlei test in #241. I found that there is a problem when an agent that contains a delegator tries to resolve an oobi for its delegatee. See the added steps in
delegation.test.ts
for a reproduction.The effects of this is that you cannot create a "contact" for the delegate, which means you cannot send an IPEX message to the delegate. This is needed for doing IPEX grant from GLEIF External to the QVI.
To reproduce this behaviour:
To explain what happens
After step 7, X nevers gets the AID of the delegator in its contact list. The oobi longrunning operation resolves with
Which only happens here: https://github.com/WebOfTrust/keria/blob/7ee5ba84c9aed5d2d21fa48d8241d39b06aadb93/src/keria/core/longrunning.py#L235-L239, when the AID is not in kevers.
Update: I have tried running the same tests using keria:latest and it works there.